skip populate_data if requested time is after interpolate time #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec90bf7.
…& make fillpatch time smart in TiogaInterface
marchdf
reviewed
Nov 20, 2024
amr-wind/CFDSim.H
Outdated
| m_during_overset_advance = flag; | ||
| } | ||
|
|
||
| bool during_overset_advance() const { return m_during_overset_advance; } |
There was a problem hiding this comment.
can you have them have different names? maybe this one should be is_overset_advance ? And the other should be set_overset_advance? Or maybe just plain overset_advance
There was a problem hiding this comment.
I think I need them a little more verbose, though
|
I like where this is going. I just had a minor thought on clarity of naming functions. |
|
The way I set it up should still be correct with multiple iterations in AMR-Wind, too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Time to debate if this is a good idea...
This is to allow for that fillpatch(new_time) that gets called by the overset solver prior to the timestep starting. The boundary information does not matter at this point in the algorithm; it'll get filled later when necessary. The downside is that the assert is much less strict, i.e., it can't tell between a mistake and this intended exception.
Any alternative would seem to rely on the code knowing whether the timestep (advance) has begun or not, e.g., if advance_states has been called. But that seems pretty complicated to set up.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: